telemety(amazonq): add tool permission to invokeLLM and mcpServerInit #1069
+22
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laileni-aws
reviewed
Jul 24, 2025
laileni-aws
reviewed
Jul 24, 2025
ashishrp-aws
approved these changes
Jul 24, 2025
laileni-aws
reviewed
Jul 24, 2025
laileni-aws
reviewed
Jul 24, 2025
laileni-aws
approved these changes
Jul 24, 2025
Contributor
|
Please address nits |
bywang56
approved these changes
Jul 24, 2025
|
/retryBuilds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Missing metric for feature new launch: built-in tools
Solution
Add tool permission to invokeLLM to have a data on tool permission set by user
Add toolNames and ToolPerms to mcpServerInit but only used for buitl-in tools when permission is updated
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.